Simplify the signatures - currently we pass this parameter to like 10 different places, some with default some without
Will be included in caching
More coherent - we have like 10 params in the config, but not this one. There is no logic behind it.
Notes
This is technically a breaking change for the DatasetAdapter and SampleProcessor classes these are internal classes and should never be used by users.
This combined with the fact that we have just a few users currently makes me strongly think that we should NOT bother with deprecation. This would increase complexity with probably no gain
What
Moving
n_image_channelsto the DataConfigWhy
Notes
This is technically a breaking change for the
DatasetAdapterandSampleProcessorclasses these are internal classes and should never be used by users. This combined with the fact that we have just a few users currently makes me strongly think that we should NOT bother with deprecation. This would increase complexity with probably no gain