search

DecisionsDev / odm-ondocker

This repository allows to deploy an IBM Operational Decision Manager topology with Docker Compose
https://odmdev.github.io/odm-ondocker/
Apache License 2.0
52 stars 40 forks source link

Fix for Dockerfile smell DL3048 #326

Closed grosa1 closed 1 year ago

grosa1 commented 1 year ago

Hi! The Dockerfile placed at "databases/postgresql/Dockerfile" contains the best practice violation DL3048 detected by the hadolint tool.

The smell DL3048 occurs when the pattern used for the label keys does not match the format recommended by official guidelines. In this pull request, we propose a fix for that smell generated by our fixing tool. We verified that the patch is correct before opening the pull request. To fix this smell, specifically, the label keys are refactored to match the correct format.

This change is only aimed at fixing that specific smell. If the fix is not valid or useful, please briefly indicate the reason and suggestions for possible improvements.

Thanks in advance.

lgrateau commented 1 year ago

Thanks we will include this PR in the next Release

lgrateau commented 1 year ago

Closing it as it's has been included in another branch