Support passing modifiers as a string and remove non-string entries - Githubissues

Decisiv / styled-components-modifiers

A library to enable BEM flavored modifiers (and responsive modifiers) in styled components.

MIT License

297 stars 11 forks source link

Support passing modifiers as a string and remove non-string entries #16

Closed andrefgneves closed 6 years ago

andrefgneves commented 6 years ago

OVERVIEW

Allows passing a single modifier as a string: <Comp modifiers="name" />.
Remove non-string entries from the modifiers array: <Comp modifiers={['name', '', null, false]} /> becomes <Comp modifiers={['name']} />

WHERE SHOULD THE REVIEWER START?

lib/utils/modifiedStyles.js

HOW CAN THIS BE MANUALLY TESTED?

Running the tests.

ANY NEW DEPENDENCIES ADDED?

No.

CHECKLIST

[X] Verify the linter and tests pass: npm run review
[X] Verify this branch is rebased with the latest master

GIF