Decisiv / styled-components-modifiers

A library to enable BEM flavored modifiers (and responsive modifiers) in styled components.
MIT License
298 stars 11 forks source link

Offers suggestions for improved typings and build processes #26

Closed andrewtpoe closed 5 years ago

andrewtpoe commented 5 years ago

OVERVIEW

Give a brief description of what this PR does.

This PR offers suggested feedback to #24. Specifically, some issues around types were found when linking this package to a project using it. There are also some new package configurations that are updated.

WHERE SHOULD THE REVIEWER START?

package.json

HOW CAN THIS BE MANUALLY TESTED?

Run the test suite. Build the package. Link the package locally to a project being built in TypeScript and ensure the types match up as expected.

ANY NEW DEPENDENCIES ADDED?

Several added, updated, and moved around. Review the package.json

CHECKLIST

Be sure all items arebefore submitting a PR for review.

GIF

Share a fun GIF to say thanks to your reviewer: https://giphy.com