Enhancement/proptype validation responsive modifiers size

Nauthiz-Jera commented 4 years ago

OVERVIEW

PR based on this open Issue: closes https://github.com/Decisiv/styled-components-modifiers/issues/27

WHERE SHOULD THE REVIEWER START?

src/styleModifierPropTypes.ts src/responsiveStyleModifierPropTypes.ts

HOW CAN THIS BE MANUALLY TESTED?

Create a component with modifiers.
Render the component in an application using an object syntax to declare the modifiers.
Do not provide a size prop
Observe no errors and no styles applied.

ANY NEW DEPENDENCIES ADDED?

No new dependencies

CHECKLIST

Be sure all items are ✅ before submitting a PR for review.

[x] Verify the linter and tests pass: npm run review
[x] Verify this branch is rebased with the latest master

GIF

Share a fun GIF to say thanks to your reviewer: https://giphy.com

Nauthiz-Jera commented 4 years ago

Thanks! Glad to help, I've made the changes per-requested. If there is any other changes you'd like please let me know.

andrewtpoe commented 4 years ago

This code is ready to merge, but doing so will cause a breaking change. Code that was previously ok will now throw PropTypes errors and may break.

This is going to be targeted at v2. The rest of v2 is still being planned, so we are going to sit on this for a little while.

andrewtpoe commented 4 years ago

I've got a v2 feature set planned out in the issues. I'm going to re-target this at that branch and merge it in now. Thanks again for your contributions!

Decisiv / styled-components-modifiers