Decisiv / styled-components-modifiers

A library to enable BEM flavored modifiers (and responsive modifiers) in styled components.
MIT License
297 stars 11 forks source link

fix: updates styled-components peer dep & other dev deps #47

Closed andrewtpoe closed 4 years ago

andrewtpoe commented 4 years ago

OVERVIEW

Give a brief description of what this PR does. closes #44

This PR updates the value of the styled-components peerDependency field to include v5. It also does a review of the uses of styled-components within the package to ensure no deprecated apis are being used.

WHERE SHOULD THE REVIEWER START?

package.json

HOW CAN THIS BE MANUALLY TESTED?

List steps to test this locally.

If it passes CI, it should be good to go. If you want though, link the branch to an app that uses styled-components v5 and ensure no peer dependency warning is displayed on install. Also ensure it works as expected in the components.

ANY NEW DEPENDENCIES ADDED?

List any new dependencies added.

None new, but I updated a few.

CHECKLIST

Be sure all items arebefore submitting a PR for review.

GIF

Share a fun GIF to say thanks to your reviewer: https://giphy.com