Closed andrewtpoe closed 4 years ago
Give a brief description of what this PR does. closes #40
This PR enhances the default style selection logic to look for present modifiers, not a present size key.
NOTE: This fix was only added to applyStyleModifiers because applyResponsiveStyleModifiers is being removed.
applyStyleModifiers
applyResponsiveStyleModifiers
e.g. /src/components/SomeComponent.js
/src/components/SomeComponent.js
src/applyStyleModifiers.ts
List steps to test this locally.
The test case and the issue description outline the issue fairly clearly. Passing the tests will prove the fix.
List any new dependencies added.
no
Be sure all items are ✅ before submitting a PR for review.
npm run review
Share a fun GIF to say thanks to your reviewer: https://giphy.com
OVERVIEW
Give a brief description of what this PR does. closes #40
This PR enhances the default style selection logic to look for present modifiers, not a present size key.
NOTE: This fix was only added to
applyStyleModifiersbecauseapplyResponsiveStyleModifiersis being removed.WHERE SHOULD THE REVIEWER START?
e.g.
/src/components/SomeComponent.jssrc/applyStyleModifiers.ts
HOW CAN THIS BE MANUALLY TESTED?
List steps to test this locally.
The test case and the issue description outline the issue fairly clearly. Passing the tests will prove the fix.
ANY NEW DEPENDENCIES ADDED?
List any new dependencies added.
no
CHECKLIST
Be sure all items are ✅ before submitting a PR for review.
npm run reviewGIF
Share a fun GIF to say thanks to your reviewer: https://giphy.com