Closed CBroz1 closed 1 year ago
New commits/changes look good to me. Anything left outstanding before we merge?
Hi @LockerM, I was able to resolve the image issue. It has to do with how chrome is installed, which is tough, because that's not something I can enforce with config files. For now, I can generate sheets, but we'll have to debug for any new machines that we use to generate sheets. I'd like to move forward with the merge, and we can consider other options for this process in the future
Testing
I took a pass to automate running the code and catch when something breaks. This does not go so far as to check that the output matches expectations, but I think we can review together and build in more assumptions based on the output we see.
When run, returns the following code coverage...
Other changes
1.0.0aX
. I propose we make better use of the patch version my reserving major versions for 'test-worthy'. This essentially makes open-beta1.1.0
. If accepted, I'll change our milestones accordingly.