search

DeclanRussell / IntelOIDenoiser

A simple implementation of Intels Open Image denoiser -> https://github.com/OpenImageDenoise/oidn
MIT License
103 stars 18 forks source link

Failed to convert beauty to float3 #1

Open RicardoMusch opened 3 years ago

RicardoMusch commented 3 years ago

Tried a multilayer exr but getting "Failed to convert beauty to float3".

Same EXR works fine in your Optix Denoiser, not sure what it could be.

Keep up the great work btw! :)

DeclanRussell commented 3 years ago

Thanks for reporting! Something to do with the type conversion logic I quickly hacked up. The difference with this denoiser is that I have to convert images to float3 to for the denoiser to ingest. Would you mind providing an example multilayer EXR so I can reproduce the issue?

RicardoMusch commented 3 years ago

Sure will get one to you soon!

Also does it actually do anything with channels in a multilayer exr? Or is it best to render all AOV's separately so we can feed it the paths to an albedo etc?

RicardoMusch commented 3 years ago

Oops, nevermind the albedo etc, thats to do with the Optix denoiser ;)

DeclanRussell commented 3 years ago

Sorry for the late reply. Currently the only workflow is to render AOVs separately and then feed paths to each. I've also replied in https://github.com/DeclanRussell/NvidiaAIDenoiser/issues/18 in regard to multilayer EXR support :)