search

DeclanRussell / IntelOIDenoiser

A simple implementation of Intels Open Image denoiser -> https://github.com/OpenImageDenoise/oidn
MIT License
103 stars 19 forks source link

Update code and build script for MAC OS #5

Closed FlorentMasson closed 3 years ago

DeclanRussell commented 3 years ago

Sorry for the late review on this. The euros being on has stagnated my development on these projects a fair amount.

The changes look great! I tried on windows and there was one issue with the OIDN include. On my machine ./contrib/"+PLATFORM.name+"/oidn/include evaluates to ./contrib/win32/oidn/include rather than ./contrib/win/oidn/include. I would have corrected this myself in the review, but github seems to be hanging due to all the files committed (This is my bad, I should really refactor the repo so that it uses submodules for these dependencies). I'll merge this PR and fix this in the main branch though.

Nice work, and thanks a lot for your contribution! 😃

DeclanRussell commented 3 years ago

I've fixed the windows include path in 3b1b093 in case you want to check it out.

FlorentMasson commented 3 years ago

amazing, thanks! 👍