DeclanRussell / NvidiaAIDenoiser

A simple implementation of Nvidia's AI denoiser
MIT License
398 stars 52 forks source link

can not use for loop #11

Closed stansu closed 5 years ago

stansu commented 5 years ago

After I launch exe and finished denoise, the command-line window won't close, so for loop don't work.

DeclanRussell commented 5 years ago

Hey @stansu, Can you give some more context about hoe you are launching the exe? Are you using some kind of batch/python script?

stansu commented 5 years ago

I'm using the batch file example you provided. When it finished, it show 'done!'.

jackyjacky1307 commented 5 years ago

I have the same problem when I using win7, but it's woking when I use win10.

DeclanRussell commented 5 years ago

Can you remove the "cmd /k" line from the end of the script? This should allow cmd to close after the script has run.

stansu commented 5 years ago

No, it still remain opened.

On Fri, Jan 18, 2019, 4:40 PM Declan Russell <notifications@github.com wrote:

Can you remove the "cmd /k" line from the end of the script? This should allow cmd to close after the script has run.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DeclanRussell/NvidiaAIDenoiser/issues/11#issuecomment-455468373, or mute the thread https://github.com/notifications/unsubscribe-auth/AJBaDCPU9bbxdys_glHjQ2bMqAORtpxZks5vEYhjgaJpZM4aB09e .

DeclanRussell commented 5 years ago

Ok I'm seeing other similar reports all on windows 7. The app was built on windows 10 so perhaps there is something specific I am missing to get it working on windows 7. I'll try and find some time soon to look into it.

stansu commented 5 years ago

Thanks for your time!

DeclanRussell commented 5 years ago

Sorry this took so long to resolve. It should be fixed in the latest version (see #13 for details). Feel free to reopen this issue if its still a problem.