search

DeclanRussell / NvidiaAIDenoiser

A simple implementation of Nvidia's AI denoiser
MIT License
398 stars 52 forks source link

what format is expect for the normals input #6

Open ultra-sonic opened 6 years ago

ultra-sonic commented 6 years ago

Hey Declan,

can you tell me the format that the denoiser expects the normals input in? I tried feeding normals in worldspace ranging from -1 to 1 in XYZ as en exr but got super weird results that look like "ghosting". My first thought is that somehow the normals buffer is corrupt. I guess you tried it with an Arnold rendering and it works for you,right?

thx in advance Oliver

ultra-sonic commented 6 years ago

what would be even better is if you could put some test images including albedo and normals into this or another NvidiaAIDenoiser-resources repo...is that doable?

DeclanRussell commented 6 years ago

Hey Oliver, Here is a snippet from the OptiX programming guide,

This buffer is expected to contain the surface normals of the primary hit in camera space. The camera space is assumed to be right handed such that the camera is looking down the negative z axis, and the up direction is along the y axis. The x axis points to the right.

Perhaps this is the source of your problem. Could you try converting your normals to camera space and trying again?

what would be even better is if you could put some test images including albedo and normals into this or another NvidiaAIDenoiser-resources repo...is that doable?

Good idea, I'll try and cook something up :)