R cmd check edits

[graemeblair]

Hi all -- per Slack message this PR addresses some issues found on the CRAN checks online that must be resolved before resubmitting: https://cran.r-project.org/web/checks/check_results_DesignLibrary.html

And a couple other small issues. And I merged in the other PR that increases the number of kinds of travis checks that are done, so that we catch some of the CRAN issues on other platforms (this will still be imperfect).

[jaspercooper]

OK thanks.

I got two notes and two errors when running devtools::check() on this branch. Suggestions on how to resolve these appreciated.

checking dependencies in R code ... NOTE
Packages in Depends field not imported from:
  ‘DeclareDesign’ ‘estimatr’ ‘fabricatr’ ‘randomizr’
  These packages need to be imported from (in the NAMESPACE file)
  for when this namespace is loaded but not attached.

A ton of these:

checking R code for possible problems ... NOTE
block_cluster_two_arm_designer: no visible global function definition

It looks like rlang's not working in the designers that depend on it anymore:

  > test_check(package = "DesignLibrary")
  ── 1. Error: (unknown) (@test_designers.R#14)  ──────────────────────────────────────────────────
  could not find function "quo_text"
  1: the_designer() at testthat/test_designers.R:14
  2: gsub("eval_bare\\(population_expr\\)", quo_text(population_expr), design_code) at /Users/jaspercooper/Dropbox/09_Software_Development/DeclareDesign_/__library/DesignLibrary.Rcheck/00_pkg_src/DesignLibrary/R/factorial_designer.R:207

I suspect all of these are interrelated

[coveralls]

Pull Request Test Coverage Report for Build 890

• 23 of 23 (100.0%) changed or added relevant lines in 5 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 100.0%

---

Totals
Change from base Build 881:	0.0%
Covered Lines:	775
Relevant Lines:	775

---

💛 - Coveralls

[jaspercooper]

OK there's a bit more work here to do before merging. @clabima has very generously offered to help me out.

[jaspercooper]

Closing thanks to @clabima who has merged this into #186