DeclareDesign / DesignLibrary

Library of Research Designs
https://declaredesign.org/library/
Other
30 stars 3 forks source link

Print messages when designer arguments are overridden #230

Open clarabicalho opened 5 years ago

clarabicalho commented 5 years ago

For example in two_arm_designer(), when both ate and treatment_mean are provided and don't match, return warning message of the sort "Arguments treatment_mean and ate are both provided. The design uses the value of treatment_mean."

jaspercooper commented 5 years ago

Yes, absolutely agree with this. Any sense of where this is occurring?

clarabicalho commented 5 years ago

This would apply to:

macartan commented 5 years ago

And some N arguments and some SD arguments I think ?

On Mon, 25 Feb 2019, 17:09 Clara Bicalho, notifications@github.com wrote:

This would apply to:

  • binary_iv arguments a, b, d, a_Y, b_Y, d_Y
  • block_cluster_two_arm, two_arm_covariate, two_arm arguments ate and treatment_mean
  • two_bytwo arguments mean... and outcome_means

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DeclareDesign/DesignLibrary/issues/230#issuecomment-467070888, or mute the thread https://github.com/notifications/unsubscribe-auth/AMJO_SeTYNSe561IdgzG4oTWWNMgt53qks5vRAqsgaJpZM4bQJ55 .

clarabicalho commented 5 years ago

Good point, this also applies to factorial argument sd and outcomes_sd.

I think the existing checks/messages in block_cluster_two_arm handle well the more complex cases of N and sd.