search

DeclareDesign / DesignLibrary

Library of Research Designs
https://declaredesign.org/library/
Other
30 stars 3 forks source link

rlang update is going to break things #248

Closed jaspercooper closed 5 years ago

jaspercooper commented 5 years ago

@clarabicalho did some detective work and found there is a {{ operator now... which I would suppose will mess with the way we're getting design code. https://github.com/r-lib/rlang/pull/742/files

@nfultz any thoughts on what to do here would be greatly appreciated, if you have time.

clarabicalho commented 5 years ago

@nfultz can correct me but I don't think it affects the designer codes, just the functions written in tests.

nfultz commented 5 years ago

I believe the rlang {{}} only applies to function calls / invocations which internally use enquos on the argument. There should be minimal/zero impact on designers-internals unless a lot of NSE has been added. I don't believe we were ever passing designers function bodies around as quosures, only as text.

clarabicalho commented 5 years ago

Doesn't DesignLibrary:::pred() use designer body as expression when source code is missing?

jaspercooper commented 5 years ago

That sounds right to me. Some of the designs do have quosures within {{{ (e.g., https://github.com/DeclareDesign/DesignLibrary/blob/master/R/factorial_designer.R#L225), but we are never doing NSE on the function bodies themselves.

Going to take a look at your PR now @clarabicalho THanks so much to both of you for the quick movement on this

jaspercooper commented 5 years ago

I think we're good here -- Please feel free to chime in if not.

Thanks everyone.