add modelsummary to tests, regression table vignette, and DESCRIPTION

DeclareDesign / estimatr

estimatr: Fast Estimators for Design-Based Inference

https://declaredesign.org/r/estimatr

Other

131 stars 20 forks source link

add modelsummary to tests, regression table vignette, and DESCRIPTION #346

Closed vincentarelbundock closed 4 years ago

vincentarelbundock commented 4 years ago

This PR supersedes this WIP: https://github.com/DeclareDesign/estimatr/pull/326

modelsummary and gt are now on CRAN, so we can add a test and a note in the vignette.

The test raises a warning because some of the estimatr objects do not have an associated nobs method. I could try to put one together in a separate PR if you think that's useful.

vincentarelbundock commented 4 years ago

Also, I put modelsummary just after texreg in the vignette. This is perhaps presumptuous, but I figured that those are the only 2 packages that work out-of-the-box without hacks. Let me know if I should re-order.

nfultz commented 4 years ago

LGTM, :+1:

vincentarelbundock commented 4 years ago

Both of my PRs (#346 and #347) used to fail on Travis. Sorry it took me so long to get back to them!

Turns out there was nothing wrong with the code. I just merged upstream master and all the checks are now green.

[this post is copied in both PRs]

vincentarelbundock commented 4 years ago

thanks a lot for the merge. changes will appear on the website next time pkgdown is deployed.