DeclareDesign / estimatr

estimatr: Fast Estimators for Design-Based Inference
https://declaredesign.org/r/estimatr
Other
131 stars 20 forks source link

Resolve notes #361

Closed lukesonnet closed 4 years ago

lukesonnet commented 4 years ago

Unable to replicate windows error, even on rhub. Not sure what to do about that. This is the error:

Check: running tests for arch 'i386', Result: ERROR
    Running 'sleep.R' [1s]
    Comparing 'sleep.Rout' to 'sleep.Rout.save' ... OK
    Running 'testthat.R' [40s]
  Running the tests in 'tests/testthat.R' failed.
  Complete output:
    > library(testthat)
    > library(estimatr)
    >
    > test_check("estimatr")
    -- 1. Error: lm robust F-tests are correct (@test-lm-robust.R#198)  ------------
    argument is of length zero
    Backtrace:
     1. clubSandwich::Wald_test(...)

    == testthat results  ===========================================================
    [ OK: 1348 | SKIPPED: 0 | WARNINGS: 0 | FAILED: 1 ]
    1. Error: lm robust F-tests are correct (@test-lm-robust.R#198)

    Error: testthat unit tests failed
    Execution halted

Flavor: r-devel-windows-ix86+x86_64
Check: running tests for arch 'x64', Result: ERROR
    Running 'sleep.R' [1s]
    Comparing 'sleep.Rout' to 'sleep.Rout.save' ... OK
    Running 'testthat.R' [38s]
  Running the tests in 'tests/testthat.R' failed.
  Complete output:
    > library(testthat)
    > library(estimatr)
    >
    > test_check("estimatr")
    -- 1. Error: lm robust F-tests are correct (@test-lm-robust.R#198)  ------------
    argument is of length zero
    Backtrace:
     1. clubSandwich::Wald_test(...)
lukesonnet commented 4 years ago

Looks like the bugs are Appveyor side. I'll be away until Monday so if you want to merge this in and resubmit then please do.