Changes to generating factors

DeclareDesign / fabricatr

fabricatr: Imagine Your Data Before You Collect It

https://declaredesign.org/r/fabricatr

Other

91 stars 11 forks source link

Changes to generating factors #187

Closed davidchall closed 2 years ago

davidchall commented 2 years ago

Fixes #186

Breaking change: draw_categorical() returns factor when category_labels is specified
Breaking change: draw_ordered() returns ordered factor instead of unordered factor
draw_ordered() no longer generates intermediate character vector

nfultz commented 2 years ago

LGTM. Thank you for updating the tests as well.

@graemeblair can you trigger a CI build? First-time contributors need a maintainer to approve running workflows. [Learn more.](https://docs.github.com/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks)

davidchall commented 2 years ago

Hi @graemeblair - looks like the builds are failing, but this isn't caused by my PR changes. Could we try restarting the builds to see if it was a transient issue?

graemeblair commented 2 years ago

Thanks for this, sorry it too long to review. LGTM!