change exception behavior

DeclareDesign / randomizr

randomizr: Easy-to-Use Tools for Common Forms of Random Assignment and Sampling

https://declaredesign.org/r/randomizr

Other

36 stars 9 forks source link

change exception behavior #65

Closed acoppock closed 6 years ago

acoppock commented 6 years ago

In re: conversation with Macartan that complete_ra(N = 1, m = 1) should be deterministic.

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling 2202ab35e0fdd0e5ba9ed15446e14cb6a5c3ae75 on fix-N-1 into 6b9a93ac5768c3d95f3fcfd27b8e413530553fc0 on master.

nfultz commented 6 years ago

If that's the decision, I would recommend deleting all the special handling for N=1, and using the normal code path instead. See my PR #66.

Also, complete_ra is pretty messy and should get cleaned up at some point.