search

DedSecInside / TorBot

Dark Web OSINT Tool
Other
2.75k stars 510 forks source link

Move log level from environment variable to CLI flag #292

Closed KingAkeem closed 9 months ago

KingAkeem commented 10 months ago

Is your feature request related to a problem? Please describe. Currently, the logging level is determined by a setting in the .env file.

Where the value is set within the .env file https://github.com/DedSecInside/TorBot/blob/289429f94d3814d562e49b80543b8a6097ec8d2a/.env#L4

Where the value is read from the .env file https://github.com/DedSecInside/TorBot/blob/289429f94d3814d562e49b80543b8a6097ec8d2a/torbot/modules/config.py#L20-L27

Describe the solution you'd like Instead of reading the value from the .env file, it can be read from the CLI flag using a verbose flag -v.

dargudear commented 10 months ago

I would like to work on this issue. Can you please assign it to me?

PSNAppz commented 10 months ago

@dargudear Great!. I'll assign it to you. Raise a PR to the dev branch once you're done.

PSNAppz commented 9 months ago

@dargudear Any updates on this one?

vedant-z commented 9 months ago

@PSNAppz @KingAkeem I have come up with some initial solution for this. If you allow me then I will make PR for this issue.

KingAkeem commented 9 months ago

@vedant-z It's all yours, we haven't heard anything back from @dargudear.

KingAkeem commented 9 months ago

I've assigned the issue to you @vedant-z, thank you for the contribution in advance.

dark-developer15 commented 9 months ago

Hey there @KingAkeem, I have made the changes, as mentioned, and am trying to test it. If I may, I would like to contribute to this issue.

KingAkeem commented 9 months ago

@dark-developer15 A pull request has already been created by @vedant-z

dark-developer15 commented 9 months ago

Yes @KingAkeem, I saw it, I was just trying to solve it and was successful, that's why I asked.

KingAkeem commented 9 months ago

@dark-developer15 you can push a PR as well, I'll merge the first correct one.

dark-developer15 commented 9 months ago

Okk sure, I'll do it. But if @vedant-z PR is good to go then, his PR should get merged, Hacktoberfest is about learning and he is doing his best 😅

PSNAppz commented 9 months ago

@dark-developer15 Why don't you look into #270?

You can also suggest new features and we'll look into it. Since Hacktoberfest23 is going on, we'll be actively reviewing the issues/features requests.