search

DedSecInside / gotor

This program provides efficient web scraping services for Tor and non-Tor sites. The program has both a CLI and REST API.
GNU General Public License v3.0
159 stars 44 forks source link

Changed `USE_TOR` default value to `true`. #40

Closed fukusuket closed 1 year ago

fukusuket commented 1 year ago

Hello, thank you for maintaining a great tool :) related PR #37

Changes Proposed

Changed USE_TOR(in the .env) default value false to true.

Explanation of Changes

IMHO. I think that most users will expect using TOR as the default behavior, so I proposed changing USR_TOR default value to true.(I'm sorry if I misunderstood the concept or use case of this tool)

If it is not appropriate to change the default value of .env, I would appreciate it if you could state in the README that the default value is false.

Regards.

KingAkeem commented 1 year ago

You are correct, true should be the default behavior. I must've left it as false whenever I was testing.

fukusuket commented 1 year ago

Thank you so much for the quick review :)