DedalusProject / dedalus

A flexible framework for solving PDEs with modern spectral methods.
http://dedalus-project.org/
GNU General Public License v3.0
513 stars 121 forks source link

Fix CFL in azimuthally symmetric runs #174

Closed evanhanders closed 2 years ago

evanhanders commented 2 years ago

Fixes an edge case CFL bug when the user assumes azimuthal symmetry (1 azimuthal point).

evanhanders commented 2 years ago

@kburns I just updated this per your suggestions and tried it out in on the ball and shell example problems (setting nphi = 1 in each). Seems to work!

evanhanders commented 2 years ago

Hi @kburns; yes something went weird with that most recent commit and rebasing. PR should now be properly rebased onto dedalus/master. Will take a look at your other comment shortly and test on an azimuthally symmetric run.

kburns commented 2 years ago

Thanks!