Bug in basis caching based on multidimensional vs scalar dealias keyword

DedalusProject / dedalus

A flexible framework for solving PDEs with modern spectral methods.

http://dedalus-project.org/

GNU General Public License v3.0

513 stars 121 forks source link

Bug in basis caching based on multidimensional vs scalar dealias keyword #203

Closed kburns closed 1 year ago

kburns commented 2 years ago

Looks like passing a scalar for dealias for a multidimensional basis will be correctly expanding, but only after caching, causing actually identical bases to be instantiated separately.

Ref: https://groups.google.com/g/dedalus-users/c/X0qr_S4sxzk/m/QzIsWtcMCAAJ

kburns commented 1 year ago

Fixed in 65ab92d8d63a2b4f10e4f7b4aec8c340158807cc.