search

DedalusProject / dedalus

A flexible framework for solving PDEs with modern spectral methods.
http://dedalus-project.org/
GNU General Public License v3.0
489 stars 115 forks source link

DirectProduct bases #275

Closed kburns closed 8 months ago

kburns commented 8 months ago

This PR adds support for direct products between bases with separable intertwiners (Cartesian and spin bases). This has primarily been implemented for and tested on axially periodic cylinders.

kburns commented 8 months ago

Tests passing (except skipped NCC tests)

lecoanet commented 8 months ago

Cylinder NCC tests sometimes fail due to transform noise. In the future we should compare the coefficient data so the tests are really tests of only the NCCs. Right now they're both tests of NCCs & transforms.