DeeChael / Concentration

Borderless support for Minecraft 1.20.6+
MIT License
4 stars 5 forks source link

[Feature Request] Customizable window size? #6

Closed Longie520 closed 4 months ago

Longie520 commented 4 months ago

Would it be possible to add a customizable window size for the borderless window?

Something similar to Borderless Mining which is only maintained up to 1.20.2 at the moment.

If not that's fine - especially that I play on a MacBook and doesn't have the best compat.

DeeChael commented 4 months ago

oh, actually I want some feedback from non-windows users, is there any problems using on macos. And I wonder it there any difference between windows and macos because I think changing the window size under borderless fullscreen mode has no different with using windowed mode.

Longie520 commented 4 months ago

It works fine on MacOS, except that the top menu bar and the Dock (equivalent to menu bar) interferes with the borderless fullscreen

Screenshot 2024-06-18 at 17 40 55

The reason that I want borderless small window is solely preference - I just don't like the action bar at the top

Screenshot 2024-06-18 at 17 43 59
DeeChael commented 4 months ago

Ok I'll consider it because I don't know where should put the option

Longie520 commented 4 months ago

Ok I'll consider it because I don't know where should put the option

Suggestions:

Possibly Mod Menu (as Borderless Mining did)

But I also saw you removing the config screen from Mod Menu from earlier versions... So a separate config screen (that needs a keybind to trigger) can also be good.

DeeChael commented 4 months ago

Ok I'll consider it because I don't know where should put the option

Suggestions:

Possibly Mod Menu (as Borderless Mining did)

But I also saw you removing the config screen from Mod Menu from earlier versions... So a separate config screen (that needs a keybind to trigger) can also be good.

actually I wanna put it in the video option page just like a vanilla option but I am not sure whether the resolution should use slider to customize or just provide a set of scaled resolution

Longie520 commented 4 months ago

actually I wanna put it in the video option page just like a vanilla option but I am not sure whether the resolution should use slider to customize or just provide a set of scaled resolution

i liked the settings page here

maybe add options like this? for example this is borderless mining's settings in 1.20.1 (and what it looks like on my desktop)

Screenshot 2024-06-19 at 20 41 57

edit: at this point i feel like im just asking for borderless mining to update to 1.21 XD but the dev seems to no longer be maintaining that mod ._.

DeeChael commented 4 months ago

actually I wanna put it in the video option page just like a vanilla option but I am not sure whether the resolution should use slider to customize or just provide a set of scaled resolution

i liked the settings page here

maybe add options like this? for example this is borderless mining's settings in 1.20.1 (and what it looks like on my desktop) Screenshot 2024-06-19 at 20 41 57

edit: at this point i feel like im just asking for borderless mining to update to 1.21 XD but the dev seems to no longer be maintaining that mod ._.

Actually one of the reason making me still in consideration is the title bar. Because when I try to remove the title bar in the borderless fullscreen mode, it turned to be native fullscreen, so I fixed it in a dirty way: manually increase the window height by 1 pixel. It won't affect the gaming experience and can fix the problem. But when player can customize the window size maybe this problem will appear again. That's why I'm a little bit concerned.

I'm not saying that your suggestion is bad but I think it should be an advanced option so maybe I'll make an extra mod to make some options of the mod customizable

Longie520 commented 4 months ago

It would be great if you can create a 1.21 fork of Borderless Mining (I can't code at all so all I can do is ask good devs :D)

DeeChael commented 4 months ago

image Good news: I implemented customization options Bad news: the interaction with the game is massed up, actual position and clickable position of the button is totally not same, so I need more time to fix it

DeeChael commented 4 months ago

Okay I fixed it. I'll release this in 1.0.7 But unluckily, to use the config screen you have to install mod menu and this config is for fabric only. Neoforge configuration will be added in 1.0.8. Thanks for your support. Have fun!

DeeChael commented 4 months ago

1.0.8 with neoforge support released

Longie520 commented 4 months ago

You are a legend. Thank you and good job!