DeeMcCart / CI_PP4_Financial_Planner

Financial_Planner: Authorative information on financial processes in Republic of Ireland
0 stars 1 forks source link

Updated Button styling not showing on register, login, logout, password reset screens #26

Closed DeeMcCart closed 1 year ago

DeeMcCart commented 1 year ago

Describe the bug A clear and concise description of what the bug is. 29/10/23: Issue #17 - the style settings don't seem to have picked up correctly - my buttons still showing as grey rather than blue submit buttons - can't understand why style not picking up, is bootstrap overriding the style settings????

To Reproduce Steps to reproduce the behavior: Try any of Register/ Login/ Reset Password/ Logout.

Expected behavior Button should appear as blue styled button Instead remains unchanged in grey.... so looks like styling not being picked up.

Screenshots If applicable, add screenshots to help explain your problem. bug-signout-screen-should-have-styled-button bug26-register-should-have-styled-button

Version:

DeeMcCart commented 1 year ago

01/11/23: OK checked usng dev tools - computed styles = transparent, comes from user agent stylesheet. Checking style.css for overrides, Checked templates/account/signup.html Think relevant piece of code is {% element button tags="prominent,signup" type="submit" %} {% trans "Sign Up" %} {% endelement %}

hmm I want to assign the classes btn-signup to this element so that it will pickup the styles in style.css , but can't work out how to do this... seems like the allauth version I have picked up is not the same version that i used in the walkthrough...

I can't figure out how to add an override class to a Django element...... my best workaround at present is: {% element button tags="prominent,signup,bold" type="submit" %} {% endelement %}

bug26-workaround-by-applying-btn-signup-to-span-directly-around-django-element:

bug26-workaround-by-applying-btn-signup-to-span-directly-around-django-element

Other than that, I can override all buttons in the styles file, but that means that even the comments button shows blue. OK - what about - if I assume the tags become classes and apply an override in styles.css to 'signup'???

FINAL SOLUTION: Replaced Django element with direct html code to invoke the button and control the classes used for styling. Example: `{% slot actions %}

    {% endslot %}`

Done for signup.html, login.html, logout.html, password_reset.html. Verified success as per screenshots below.

DeeMcCart commented 1 year ago

bug26-resolved-signup-page bug26-resolved-signup-page

bug26-resolved-password-reset-page

bug26-resolved-password-reset-page

bug26-resolv bug26-resolved-signin-page ed-signin-page

bug26-resolved-signout-page

bug26-resolved-signout-page

DeeMcCart commented 1 year ago

closed