search

Deech08 / whampy

Python Package to Interact with, Visualize, and Analyze the Wisconsin H-Alpha Mapper - Sky Survey
BSD 3-Clause "New" or "Revised" License
8 stars 1 forks source link

Perseus arm image does not match the on in the docs [BUG] #8

Closed Gabriel-p closed 4 years ago

Gabriel-p commented 4 years ago

Describe the bug Documentation inconsistency

To Reproduce Following the docs here

>>> fig = perseus_arm.intensity_map(colorbar = True, s_factor = 2 cbar_kwargs={"orientation":"horizontal"})

Also, notice there's a , missing after factor = 2.

Expected behavior Same image output as the one displayed in the docs.

Screenshots This is what I get:

Figure_1

HeloiseS commented 4 years ago

Just to say I tested this and got the same result as @Gabriel-p - it doesn't seem to be an isolated problem.

Deech08 commented 4 years ago

The get_spiral_slice method was missing a wrap_at_180 = True keyword to be set in the tutorial. Adding that fixes the problem. I've updated that in the docs and fixed the missing comma, which will be reflected in the next commit. I will update this issue and close it after that commit is pushed.

Deech08 commented 4 years ago

Actually - theres something else happening that i didn't notice. I will look into it and actually fix it soon!

Deech08 commented 4 years ago

Issue actually arose from an updated lv-track file. I've addeed a lrange=[0,50] keyword to the get_spiral_slice example that gives a close match to the original image. I also updated the example image to show an exact reproduction. This will be live after my next commit in the future. once that commit is pushed i will close this issue.