Deep-MI / BrainPrint

A python-only derivative of the original BrainPrint scripts
MIT License
11 stars 9 forks source link

Update to latest lapy #12

Closed kdiers closed 1 year ago

kdiers commented 1 year ago
codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@1150253). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage        ?   27.19%           
=======================================
  Files           ?        8           
  Lines           ?      353           
  Branches        ?       43           
=======================================
  Hits            ?       96           
  Misses          ?      255           
  Partials        ?        2           
Flag Coverage Δ
unittests 27.19% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

kdiers commented 1 year ago
m-reuter commented 1 year ago
  • Maybe consider specifying lapy>=1.0.0 requirement in pyproject.toml if that's possible.

specifying the version should be possible, not sure what the exact formatting is, but you should do that. I think you can specify: lapy = "^1.0.0" (or 1.* or ~1 ) which in our case are all the same meaning we allow anything >= 1.0 and < 2.0. Maybe use the ^ character as it means upward until the first non-zero number changes.

  • Please check version given in pyproject.toml (currently 0.4.0-dev) - is that correct?

yes, 0.3.0 is our last release so dev is now 0.4.0-dev until we release 0.4 .