codecov[bot]
commented
1 month ago Codecov Report
Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.
Project coverage is 63.97%. Comparing base (
90acfbb) to head (4b641e7). Report is 47 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| brainprint/cli/help_text.py | 0.00% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #29 +/- ## =========================================== + Coverage 26.00% 63.97% +37.97% =========================================== Files 8 8 Lines 350 322 -28 Branches 43 39 -4 =========================================== + Hits 91 206 +115 + Misses 256 97 -159 - Partials 3 19 +16 ``` | [Flag](https://app.codecov.io/gh/Deep-MI/BrainPrint/pull/29/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Deep-MI) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/Deep-MI/BrainPrint/pull/29/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Deep-MI) | `63.97% <96.00%> (+37.97%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Deep-MI#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR aims at removing the FreeSurfer dependencies from, and adding additional automated tests to the brainprint software.
For the creation of surfaces from voxel-based segmentations, we have replaced FreeSurfer's marching cube algorithm by scikit-image's marching cube algorithm. Similarly, other FreeSurfer binaries have been replaced by custom Python functions. As a result, a parallel FreeSurfer installation is no longer a requirement for running the brainprint software.
We have changed / removed the following composite structures from the brainprint shape descriptor due instable results in our evaluations of the proposed new version of the software: the left and right striatum (composite of caudate, putamen, and nucleus accumbens) and the left and right ventricles (composite of lateral, inferior lateral, 3rd ventricle, choroid plexus, and CSF) have been removed; the left and right cerebellum-white-matter and cerebellum-cortex have been merged into left and right cerebellum.
These changes are expected to BREAK COMPATIBILITY with earlier versions (0.4.0 and lower): specifically, numerical values for the brainprint shape descriptor that are obtained from the proposed new version are expected to differ from earlier versions when applied to the same data, but have been shown to remain highly correlated with earlier results in our evaluations.
Minor remaining TODOs:
pytestworkflow currently still needs to be run manually, and currently still installs the pre-release version of thelapypackage directly from its repository. This should be changed once the new lapy is released and available on pypi.pyproject.tomlmay need to be adapted to reflect the desiredlapyversion.