Deep-MI / FastSurfer

PyTorch implementation of FastSurferCNN
Apache License 2.0
435 stars 115 forks source link

Docker build workflows #517

Closed m-reuter closed 1 month ago

m-reuter commented 2 months ago

Description

Currently docker build workflow seem to be broken:

https://github.com/Deep-MI/FastSurfer/actions/runs/8897578099

Maybe this is still not adjusted to the current build workflow? It started when I published a release, the CPU version build (but did not upload, which could be because this version is already published there, or because it does not understand the all-tags flag?).

The GPU version never builds.

We should discuss how we want this to work in the future and fix it. One issue is that optimally the version that is uploaded to docker should also be the image that was tested with out test pipeline. So maybe we should disable the workflow?

dkuegler commented 2 months ago

deleted my comment that was incorrect.

dkuegler commented 2 months ago

So the message is

System.IO.IOException: No space left on device : '/home/runner/runners/2.316.0/_diag/Worker_20240430-181019-utc.log'

No space is not an issue we can easily solve. Maybe large runners. Alternatively, this can also be run on private runners instead of on github runners...

dkuegler commented 2 months ago

I had another look at the CPU build and that is due to a bug in the script

Run docker push --all-tags ***/fastsurfer:cpu-v.2.2.0
  docker push --all-tags ***/fastsurfer:cpu-v.2.2.0
  shell: /usr/bin/bash -e {0}
tag can't be used with --all-tags/-a
Error: Process completed with exit code 1.
dkuegler commented 2 months ago

I just realized we are a bit lucky, because re-building these images would have changed the (versioned) static images for Fastsurfer. That means same version docker Images may have lead to different images based on when they were pulled...

m-reuter commented 1 month ago

I stoped automated runs of this workflow in dev and stable for now. Once we decided how to do this in the future, we can delete those files.