Fix cholmod and related issues - Githubissues

Deep-MI / LaPy

Toolbox for Differential Geometry on Triangle and Tetrahedra Meshes (FEM, Laplace, Poisson, Heat Flow ...)

MIT License

60 stars 13 forks source link

Fix cholmod and related issues #24

Closed kdiers closed 1 year ago

kdiers commented 1 year ago

This pull request intends to solve the following issues:

use of scipy.sparse instead of scikit-sparse
inconsistent defininition and behavior of use_cholmod flag
incomplete import of sksparse.cholmod

It also changes the behavior of the use_cholmod flag:

if set to true and if scikit-sparse import fails, will no longer fall back to LU decomposition, but throw an error
use_cholmod is now set to false by default, i.e. LU decomposition will be used by default

Minor changes:

added use_cholmod argument to ShapeDNA and other submodules
fixed eigsh import issue
updated readme