Deep-Symmetry / beat-link-trigger

Trigger events and automate shows in response to events on Pioneer CDJs
Eclipse Public License 2.0
422 stars 37 forks source link

Closing BLT via task manager keeps carabiner open. #138

Closed VNRARA closed 1 year ago

VNRARA commented 2 years ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior: Close BLT via task manager.

Expected behavior A check to see if BLT is still open and auto close itself; but it stays running in the background preventing another instance from using the port.

Screenshots image

Exceptions and Stack Traces NA

Desktop (please complete the following information):

Additional context If unaware the user will not find carabiner open in taskbar so it'll induce the port is being used problem.

brunchboy commented 2 years ago

This should not be a problem; Carabiner is designed to run outside the context of BLT. You can install it and launch it manually before running BLT, and BLT will find it and use it rather than trying to launch its own copy. If you are running into issues with the port already being in use, then it means something has gone wrong with Carabiner itself. You’ll need to dig a bit deeper. Carabiner is never going to quit itself just because BLT is not running, Carabiner is used in many projects that have nothing to do with BLT.

brunchboy commented 2 years ago

In general, however, I would discourage the practice of killing BLT using the task manager; it prevents it from doing important cleanup, and can cause loss of data that it would have otherwise warned you about and prompted you to save.

brunchboy commented 2 years ago

I wonder if this might be a Windows firewall issue? In any case, I will leave this issue open for a while in case you can find and share more details about what is actually causing the problem. If nothing else, that could lead to another entry in the troubleshooting guide.

VNRARA commented 2 years ago

"killing BLT using the task manager;" I only did that after having some connection issues, thinking the killing the blt-proces would also fix the carabiner issue, not knowing carabiner was a seperate exe running. I thought that ideally a helper type app would close itself after not find a connection with the main program.

brunchboy commented 2 years ago

Carabiner is its own thing. It can be used by multiple applications at once, or simply wait until an application wants to use it.

brunchboy commented 1 year ago

If I hear nothing more about this, I will close the issue shortly.

VNRARA commented 1 year ago

Haven't been able too use for a while too sadly.