search

Deep-Symmetry / crate-digger

Java library for fetching and parsing rekordbox exports and track analysis files.
Other
139 stars 18 forks source link

Add color_id for extended cue memory cues and loops #13

Closed ehendrikd closed 4 years ago

ehendrikd commented 4 years ago

Whilst integrating Create Digger based Rekordbox export media into Mixxx found that cue_extended_tag_t.color_code, cue_extended_tag_t.color_red, cue_extended_tag_t.color_green, cue_extended_tag_t.color_blue are correct for imported hotcues, however contained junk for memory cues and loops.

cue_extended_tag_t.color_id now gives a correct color table value, as used when also coloring tracks.

brunchboy commented 4 years ago

Thank you, this is very timely, as I am planning to do a release today! 😄

brunchboy commented 4 years ago

Thanks again for reporting this. I only very recently purchased hardware that can display colors at all, so this has been a very unexamined corner of the file format for me.

ehendrikd commented 4 years ago

No problem. Was pleasing to be able to contribute something back to your existing hard work :)

brunchboy commented 4 years ago

This is what open source is all about! I’m delaying the release until I can figure out all the implications of this. I still have to figure out where this byte is found within the dbserver protocol message that sends one of these extended cues, and this affects three different projects, dysentery (the protocol documentation), crate digger itself, and beat link, which embeds crate digger. But tonight I am enjoying the Porter Robinson virtual music festival, Secret Sky. :smile:

brunchboy commented 4 years ago

Found it! This byte is at offset 0x22 in the entry structure of extended cue list response messages from dbserver. Updating that section of the documentation now, and resuming preparations to release new versions of the libraries and Beat Link Trigger.