search

Deep-Symmetry / crate-digger

Java library for fetching and parsing rekordbox exports and track analysis files.
Other
135 stars 18 forks source link

PVBR tag figured out #34

Closed CodeKill3r closed 1 month ago

CodeKill3r commented 2 months ago

due to a fortunate coincidence the proper offset format (or more likely the proper start address) has been figures out (said file had an exact 0x1000 offset before the first valid mp3 syncword)

also gives a small tip for seeking better in mp3 files

brunchboy commented 2 months ago

Thanks for this! I won’t have time to analyze and confirm it until I am back from Europe, but can you update the Kaitai Struct definition as well as the documentation as part of this PR? That is what will allow people to actually access the entries, and it sounds like you want it to be called entries rather than index.

Also, I think you forgot to remove the subscript 2 from your new entries section in the documentation; as it is the only such section, it does not need a number.

CodeKill3r commented 1 month ago

Thanks for this! I won’t have time to analyze and confirm it until I am back from Europe, but can you update the Kaitai Struct definition as well as the documentation as part of this PR? That is what will allow people to actually access the entries, and it sounds like you want it to be called entries rather than index.

Well, technically those are offsets except the last one, which is a counter, but can be called whatever.. (which i have written even in the topic 10years ago: https://reverseengineering.stackexchange.com/questions/4311/help-reversing-a-edb-database-file-for-pioneers-rekordbox-software )

Also, I think you forgot to remove the subscript 2 from your new entries section in the documentation; as it is the only such section, it does not need a number.

just wanted to share the info not really to update all relying stuff (would be nice to be able to see the proper result of my edits not just the cryptic page-builder version...)

brunchboy commented 1 month ago

just wanted to share the info not really to update all relying stuff

Then a pull request is not the appropriate approach. Feel free to discuss things in the Zulip community. If you decide you are willing to commit the time and energy to carefully write complete and consistent documentation, and update the relevant definition files to match, by all means add more commits to this pull request. If the read me is not sufficiently clear about how to run Antora locally so that you can see what you are writing, then please let me know where it is lacking. I don’t know what you mean by “the cryptic page-builder version” I am afraid.

brunchboy commented 1 month ago

And just to be clear, I appreciate any and all information that you have shared and may share in the future, and will try to merge this once it’s fully correct and detailed (or I am back home and have time to research the situation enough myself to add any clarifications and missing definitions). But for the future, when you have new information that is still being explored and fleshed out, it is best to discuss it first on Zulip, and then create a PR once all the details are known and correct.

CodeKill3r commented 1 month ago

I thought it was something like a wiki, so i could help out with the missing info - then no, you have to fork it.. fine, then it still not showed up, ok, so maybe share it with you by pr? -- then do this and that more.... I'm not into this project, does not follow, haven't used, just wanted to help with my new discovery -- but feels like i have to jump all kinds of hoops (i have never heard of before) to do that Now i see the PR was not the best idea -- or even sharing.... (seems like the guy asked on stackexchange got credit but the one answered (me) is not)

brunchboy commented 1 month ago

As I have said multiple times, when I am back home from vacation I will have time to review this and likely merge it, or at least revise it and update the mapping file and documentation, and which point of course you will get credit, as does everyone who has shared discoveries. Until I am back home, I can not do any of these things. I am sailing with very limited internet access, and no Pioneer hardware.

I explained how to use Zulip if you want to discuss ideas to help them get into good enough shape to create PRs in the future, and I thank you for what you have already contributed.

brunchboy commented 1 month ago

I tried to reopen this now that I am back home, but you have deleted the branch, so that will make it impossible for it to show up as a contribution from you. If you would like to resubmit it now that I am ready to work on it with you, I encourage you to do so. Otherwise, best of luck finding ways to contribute constructively to projects in the future.