Deep-Symmetry / crate-digger

Java library for fetching and parsing rekordbox exports and track analysis files.
Other
139 stars 18 forks source link

Add end_beat and phrase style 3 #6

Closed mganss closed 5 years ago

mganss commented 5 years ago

In rare cases a third phrase style can occur. Phrases in this style are displayed in even more subdued colors than bridge-verse style. The only difference to bridge-verse style is that verses 1-3 and 4-6 are merged into VERSE1 and VERSE2 resp. I have used the default case in the switch (_) for this to be on the safe side should there be other phrase style we don't know yet. I have not added another enum for this style since it's rare and mostly identical to the bridge-verse style (plus you can't have the same label for different numbers in an enum :)

Also, I have identified another field from the header. This is the beat number where last phrase ends. The end of all phrases except the last one is implicitly defined by the start of the following phrase. The last phrase, however, can end before the track ends (mostly silence).

brunchboy commented 5 years ago

Thanks again for all these great contributions!