DeepBlueCLtd / Fi3ldMan

Field Service Manual with advanced data exploitation
https://deepbluecltd.github.io/Fi3ldMan/
Apache License 2.0
1 stars 1 forks source link

#27 : Introduce image element in class - dtd updated #35

Closed brahnavank closed 1 year ago

brahnavank commented 1 year ago

Changes to update class element Introducing images elements

Fixes #27

IanMayo commented 1 year ago

Thanks. Do we need to specify that images can only contain an image element?

IanMayo commented 1 year ago

Could you use three different images please? Some samples here: https://github.com/DeepBlueCLtd/LegacyMan/tree/develop/data/Britain_Standalones/Content/Images

brahnavank commented 1 year ago

Could you use three different images please? Some samples here: https://github.com/DeepBlueCLtd/LegacyMan/tree/develop/data/Britain_Standalones/Content/Images

updated

brahnavank commented 1 year ago

Thanks. Do we need to specify that images can only contain an image element?

Yes

brahnavank commented 1 year ago
  • include published output
  • remove structural comments
  • can't the image elements be expressed in more compact way? <image/> instead of <image></image>
  • we do not need the images block under body

image

Almost all class instances have a block of images.

The pages start with 3 images presented in a horizontal row at the top, though others may be present later on.

We should introduce an optional list of images at the top of the class element.

I guess we could have a compulsory images element after summary, but then the children are optional. Actually - I like this approach, since the placeholder for the images will always be there when creating a new document.

maybe we should do the same for propulsion, signatures, remarks?

It was stated in issue

IanMayo commented 1 year ago

It was stated in issue

Sure, we require the images element that is at the top of the page. We don't require another images in the body.

brahnavank commented 1 year ago

I guess we could have a compulsory images element after summary, but then the children are optional. Actually - I like this approach, since the placeholder for the images will always be there when creating a new document.

IanMayo commented 1 year ago

Aah yes, sorry for the confusion. I meant the existing one, before the summary.

brahnavank commented 1 year ago

Aah yes, sorry for the confusion. I meant the existing one, before the summary.

  • [x] Please make the children of body compulsory - so they are already present in new documents, and when we port the legacy data. On publish we'll have to omit the element if it is empty. image

Changes done, output generated and update.