Closed brahnavank closed 1 year ago
Thanks. Do we need to specify that images
can only contain an image
element?
Could you use three different images please? Some samples here: https://github.com/DeepBlueCLtd/LegacyMan/tree/develop/data/Britain_Standalones/Content/Images
Could you use three different images please? Some samples here: https://github.com/DeepBlueCLtd/LegacyMan/tree/develop/data/Britain_Standalones/Content/Images
updated
Thanks. Do we need to specify that
images
can only contain animage
element?
Yes
- include published output
- remove structural comments
- can't the image elements be expressed in more compact way?
<image/>
instead of<image></image>
- we do not need the
images
block underbody
Almost all class instances have a block of images.
The pages start with 3 images presented in a horizontal row at the top, though others may be present later on.
We should introduce an optional list of images at the top of the class element.
I guess we could have a compulsory images element after summary, but then the children are optional. Actually - I like this approach, since the placeholder for the images will always be there when creating a new document.
maybe we should do the same for propulsion, signatures, remarks?
It was stated in issue
It was stated in issue
Sure, we require the images
element that is at the top of the page. We don't require another images
in the body
.
I guess we could have a compulsory images element after summary, but then the children are optional. Actually - I like this approach, since the placeholder for the images will always be there when creating a new document.
Aah yes, sorry for the confusion. I meant the existing one, before the summary.
body
compulsory - so they are already present in new documents, and when we port the legacy data. On publish we'll have to omit the element if it is empty.
Aah yes, sorry for the confusion. I meant the existing one, before the summary.
- [x] Please make the children of
body
compulsory - so they are already present in new documents, and when we port the legacy data. On publish we'll have to omit the element if it is empty.
Changes done, output generated and update.
Changes to update class element Introducing images elements
Fixes #27