DeepBlueCLtd / LegacyMan

Legacy content for Field Service Manual
https://deepbluecltd.github.io/LegacyMan/index.html
Apache License 2.0
2 stars 0 forks source link

Properties of class/unit #100

Closed rnllv closed 1 year ago

rnllv commented 1 year ago

Class/unit should have the following properties.

@IanMayo, the DataBrowser project had the following properties for Class/Unit for which I need your help to map to the contents in HTML.

Also, where do we map these class/unit properties in the HTML source?

image

image

Country should have

IanMayo commented 1 year ago

Yes, these structures require clarification.

After stakeholder endorsement, switch to attribute names in data.

IanMayo commented 1 year ago

Ok, we have this data in three places:

  1. Propulsion Table within Propulsion class page
  2. Within Summary Table at top of class page
  3. Within class summary on a country/category page.

For the above listing, the items are listed in descending order of provenance.

They are listed in ascending order of likely to be present in the data. I think we process them in reverse order in the parser, so we can handle that provenance by just overwriting the previous value of a field.

The tables are also listed in ascending order of how predictable the layout will be. There can be quite a lot of variety in the Propulsion Table, according to what type of platform it is.

The class summary columns are the same as those present in our mock data for a country.

rnllv commented 1 year ago

I think we process them in reverse order in the parser, so we can handle that provenance by just overwriting the previous value of a field.

Got it. Just like how we treat class attributes in Tonals section.

The tables are also listed in ascending order of how predictable the layout will be. There can be quite a lot of variety in the Propulsion Table, according to what type of platform it is.

Does our mock cover this?

IanMayo commented 1 year ago

Does our mock cover this?

Yes. Unit A of France. Propulsion Table: image

Class summary: image

Country summary: image

rnllv commented 1 year ago

Execution steps:

1) Finalize the attributes of class/unit based on the three tables (Country Summary, Class Summary, and Propulsion System). It'll be a union of properties from all these 3 tables. 2) Define a class object that can hold three sets of (similar) attributes 3) Change class parser such that attribute values are derived based on multiple matching headers instead of index positions for Propulsion System. Index positions are consistent only for Class and Country summary. Do this for tonal attributes as well. 4) Read "Class Summary" table and extract class attributes. (Other two tables are already being read) 5) Process the class (as defined in step 1) to create the class required to be exported to DataBrowser. This will be the provenance processor.

IanMayo commented 1 year ago

based on headers

Sadly, that's not quite the case. For Country Summary and Class Summary the cell contents are predictable. Note: that in Class Summary there may even be some variety in the labels - though the contents are consistent.

It's the Propulsion System table where we need to allocate according to headers. We may end up with some lookup tables to allow for slight variance in the labels provided.

rnllv commented 1 year ago

Sadly, that's not quite the case. For Country Summary and Class Summary the cell contents are predictable. Note: that in Class Summary there may even be some variety in the labels - though the contents are consistent.

Ahh okay, then we'll stick with index based retrievals for Country and Class summaries.

It's the Propulsion System table where we need to allocate according to headers. We may end up with some lookup tables to allow for slight variance in the labels provided.

Yep, will work on header based retrieval for Propulsion Systems. Right now this uses the same index based retrieval as used for Class and Country summary.

rnllv commented 1 year ago
  1. Finalize the attributes of class/unit based on the three tables (Country Summary, Class Summary, and Propulsion System). It'll be a union of properties from all these 3 tables.

@IanMayo, this will be finalized attributes of unit/classes. Please check if you want to modify the names on any Finalized Attribute

Note: live document to hold this data available here

Finalized Attribute Reference in Propulsion System Reference in Class Summary Reference in Country Summary
Cruise Plant Cruise Plant, Propulsion Drive Propulsion
Boost Plant Boost Plant N. A. N. A.
Reduction Ratio Reduction Ratio R:R Reduction Ratio
Max TRPM Max TRPM N. A. N. A.
Shaft X Blade Shaft X Blade Shaft X Blade Shaft X Blade
Range Range N. A. N. A.
Max. Speed Max. Speed Max. Speed Max. Speed
Av. TPK Av. TPK Av. TPK (Guide) Av. TPK
Max. SRPM Max. SRPM N. A. N. A.
Mode N. A. Mode N. A.
Designator N. A. N. A. Designator
rnllv commented 1 year ago

Execution steps:

  1. Define a class object that can hold three sets of (similar) attributes [In Progress]
IanMayo commented 1 year ago

Defer this, now that we're pursuing alternate strategy

IanMayo commented 1 year ago

Defer this level of analysis for a future phase