search

DeepBlueCLtd / json-schema-editor

JSON Editor focussed on developing/editing JSON Schema documents
https://deepbluecltd.github.io/json-schema-editor/
GNU General Public License v3.0
9 stars 2 forks source link

Schema Editor in Action #24

Open joshuafontany opened 5 years ago

joshuafontany commented 5 years ago

Hi Ian, everyone,

First, I'd like to give a great big mahalo (thanks!) to all of you for this excellent adaptation of json-editor. It allowed me to experiment with your prodution and development demo pages, and debug my own project.

I have integrated json-editor and json-schema-editor (as a "mode":"design" option) into TiddlyWiki5. Tiddlywiki is a fully responsive javascript wiki environment, so you can see the kind of dynamic editing that is possible when you can hide or show the data objects at whim, change where an editor points to by selecting from a dropdown, etc.

I think it is definitely worth branching json-editor to directly incorporate your changes and throw them a pull-request to merge them back into the core. Mahalo again, and have a great week.

Repository: https://github.com/joshuafontany/TW5-jsoneditor

Demo Wiki: https://joshuafontany.github.io/TW5-jsoneditor/

IanMayo commented 5 years ago

Hello there @joshuafontany - that's really, really exciting.

I've been aware of TiddyWiki for at least the last 10 years (though I wasn't aware of the TiddyWiki5 rewrite).

Did you imagine our changes going back in as another JSON-Editor demo? Or via some other means?

joshuafontany commented 5 years ago

Because of the way Tiddlywiki renders the DOM I had to throw away the mutator syntax (it has its own behind-the-scene's "widget-tree" model and refresh mechanism) and I found it much easier to just patch your Properties button code directly into my local json-editor.min.js file into the object editor section.. That, along with the auto-suggestions from the meta-schema are key features that belong in the core json-editor. I think the only other thing I really changed was to add all of the 'format' options to the Object & Array properties in the meta-schema (lots more than grid). Having an option to set a json-editor instance into 'design' mode like I demonstrate in my wiki would be one way to merge the functionality back and be able to turn it on or off.

Best, Joshua F