search

DeepBlueRobotics / DeepBlueSim

MIT License
8 stars 0 forks source link

Consider adding a PoweredHingedJoint proto that include a motor, encoder, and brake #51

Closed brettle closed 4 months ago

brettle commented 4 months ago

The idea would be to have a PoweredHingedJoint.proto that allows the user choose an FRC-legal motor, and automatically includes a PositionSensor and a Brake, so that the user doesn't need to add each of them manually.

brettle commented 4 months ago

I had originally envisioned the user selecting the motor type and encoder type from drop downs and hiding the fact that there was a brake. For technical reasons that turns out not to be practical, so instead the PoweredHingeJoint will effectively be a HingeJoint that has been prepopulated with a default motor, encoder, and a brake, and if the user changes the devices to an illegal combination (eg no brake, or spark controller but no encoder, or non spark controller with a builtin encoder), a helpful error message will be displayed in the Webots console.

brettle commented 4 months ago

Fixed by PR #71.