Some suggested changes to #74. It might be easier to read each of these commit diffs individually, but they're mostly small (1-3) line changes, so reading the full diff shouldn't be too bad either.
Commit 1 removes unnecessary calls to String.format/StringBuilder (concatenation) and the need for level guards by using System.Logger.Log(Level, String, Object...) methods.
Commit 2 changes a few things to improve readability and renames some variables to better reflect their function.
Commit 3 updates DeepBlueSimPlugin.groovy to only create the dbsDir variable (and only call File.mkdirs()) once.
Commit 4 reorders some member modifiers to conform to Java conventions.
Some suggested changes to #74. It might be easier to read each of these commit diffs individually, but they're mostly small (1-3) line changes, so reading the full diff shouldn't be too bad either.
String.format
/StringBuilder
(concatenation) and the need for level guards by usingSystem.Logger.Log(Level, String, Object...)
methods.DeepBlueSimPlugin.groovy
to only create thedbsDir
variable (and only callFile.mkdirs()
) once.