Add-support-for-linear-motors

DeepBlueRobotics / DeepBlueSim

MIT License

8 stars 0 forks source link

Add-support-for-linear-motors #82

Closed brettle closed 3 months ago

brettle commented 3 months ago

Extract common motor proto def into wpimotor.js.
Add WPILinearMotorBase.proto, and *LinearMotor.proto.
Extract motor specs into wpimotor.js.
Add PoweredSliderJoint.proto.
Add elevator to robot.
Add simple smoke test.

brettle commented 3 months ago

~~@CoolSpy3, although this isn't yet complete, please take a look and let me know if you have questions/concerns about the direction I'm headed. Thanks!~~

brettle commented 3 months ago

Actually, I think is ready for review now.

brettle commented 3 months ago

would it make sense to just have a singular WPILinearMotor and WPIRotationalMotor that extend their respective base classes and provide a dropdown to select the motor type, or is that just me oversimplifying?

I really like that idea but would prefer to leave it for a separate PR.