search

DeepBlueRobotics / DeepBlueSim

MIT License
8 stars 0 forks source link

Fix-file-locking #91

Closed brettle closed 3 months ago

brettle commented 3 months ago

Move file locking to WebotsSimulator to fix #90 and ensure endCompetition() is always called to at least partially fix #85.

Also makes WebotsSimulator constructor take the robot class instead of making the run() method take a robot instance. That helps discourage the test code from instantiating a robot because doing so might cause WPILib to try to start a NetworkTables server when another test already has one running.

CoolSpy3 commented 3 months ago

Whoops, I hit approve while forgetting that I had suggestions (too excited about getting tests working) :/ My bad.

brettle commented 3 months ago

The first time I ran this, testShaftRotatesInAutonomous failed, but I've tried it again, and it seems to work now, so it may just be a case of a non-ideal testing environment

Opened issue #94 to cover this.