search

DeepBlueRobotics / RobotCode2018

All of our code for FRC's 2018 game: FIRST Power Up.
5 stars 11 forks source link

Intake does not intake cubes after the first one #110

Open brettle opened 6 years ago

brettle commented 6 years ago

Mackenzi, Alice, Josh and I noticed this at Maker Faire. We could intake one cube and eject it, but then could not intake a second cube (the wheels would not spin in the intake direction when pressing the associated button). The problem would go away if we restarted the code though, so it was clearly a code problem. My theory is that it thinks a cube is still in the intake even after it has been ejected.

brettle commented 6 years ago

Intake does not intake cubes after the first one

doawelul commented 6 years ago

Resolved through latest DriverStationComputer commit.

brettle commented 6 years ago

Why was this reopened?

doawelul commented 6 years ago

I assumed that we wanted to test in a competition environment to make sure it is resolved before we close it.

brettle commented 6 years ago

If you were able to reliably reproduce the problem before the fix and attempts to reproduce the problem after the fix reliably failed, you should close the issue. If it comes up again in the future, we can always reopen it.

As a side note, when closing an issue, it's best to mention the specific commit(s) which contain the fix so that they can be reviewed. For example, this bug was fixed by dccf8a7508065f6d819fa1b55e6b6c2cced7af01.

Also, when writing the commit message, if you write #110 instead of "Issue 110", GitHub will make that a link to the issue.