search

DeepBlueRobotics / RobotCode2024

Other
4 stars 1 forks source link

Improved auton shooting and intake #93

Closed Rand0mAsianKid closed 3 months ago

Rand0mAsianKid commented 3 months ago

-Implemented a new way to align to speaker using math. On command AlignDrivetrain -Implemented a new way to Intake using math. On command AlignToNoteMath and DriveAndIntake(please take a good look at it and review it thoroughly) -Improved the autons and have them use these commands

List of Autons we should stick to at Sunset: Center-Auto Ruiner Left-Auto Ruiner Right-Auto Ruiner

Center Field Limelight(No Preload) Center Field Limelight

Center Limelight 4 Piece Left Limelight 4 Piece Right Limelight 4 Piece

Center Limelight 1 Piece Left Limelight 1 Piece Right Limelight 1 Piece

Backup-Left Backup-Right Backup-Center

Center-Forward Left-Forward Right-Forward

FriedLongJohns commented 3 months ago

@Rand0mAsianKid please update this branch with master (when u go to the PR on github, scroll down and there's an "Update branch" button. Hit it and fix it, please.)

FriedLongJohns commented 3 months ago

For this code, I'm requesting a full 2 or more approvals.

Rand0mAsianKid commented 3 months ago

So if we test this during practice match and it works, would you approve it?

brettle commented 3 months ago

So if we test this during practice match and it works, would you approve it?

Given the number of autos involved I think it would make more sense to first test them all in simulation and then consider testing a subset in practice matches. Practice matches are a scarce resource. It's up to your competition commander whether it's worth using them to test this. Personally, I'd also want my above questions answered/addressed. I'd also do a more thorough code review once that is done and I'm told the autos work in simulation.