search

DeepBlueRobotics / lib199

Code that we reuse in different projects/years.
Other
2 stars 0 forks source link

Fix Sporadic Temperature Reporting #41

Closed CoolSpy3 closed 1 year ago

CoolSpy3 commented 1 year ago

Looks good but recommend waiting on this until after comp. Note that your fix only addresses sporadic temp reporting. If the temp sensor is broken in a way that causes it to consistently report a false high temp, the motor will still be shut down. Since the 2023 bot still has a motor with a questionable temp sensor on it, this remains a risky change.

I'm fine to wait until after comp. In my opinion, a motor with a faulty temp sensor should be disabled because 1) we cannot safely ensure it stays in a safe temperature range, and 2) If the temp sensor is broken, it's not improbable that there is damage to the motor or encoder as well.

CoolSpy3 commented 1 year ago

Everything looks good to me! Just gotta test it. I'm assuming you can just run Test Robot Code in lib199, but you intend to do other tests?

We probably should test on the actual robot to see if it fixes the arm problem.

CoolSpy3 commented 1 year ago

Having something that records these kinds of errors in an organized manner instead of spiting them to Driver Logs might be a good feature for your GUI :)

Careful. You'll give me ideas ;P