DeepBlueRobotics / lib199

Code that we reuse in different projects/years.
Other
2 stars 0 forks source link

Don't clear sticky faults #96

Open brettle opened 1 month ago

brettle commented 1 month ago

https://github.com/DeepBlueRobotics/lib199/blob/68f09adae26c396c1d201b7d2e50994a98fff3de/src/main/java/org/carlmontrobotics/lib199/MotorErrors.java#L73

Right now we clear sticky faults as soon as we detect them (and then they aren't reported again unless they reappear). This makes it harder to know they occurred in the first place. Instead, we should require that the user manually clear them (either with the REV client or possibly with a new dashboard button) so that they will be encouraged to investigate them.