search

DeepGraphLearning / KnowledgeGraphEmbedding

MIT License
1.24k stars 264 forks source link

Question about relaxing RotatE #12

Closed Chen-Cai-OSU closed 4 years ago

Chen-Cai-OSU commented 5 years ago

Hello,

I was wondering have you tried removing the modulus constraint (in RotatE, the modulus of each r_i is 1) and see if that helps?

Thank you.

Edward-Sun commented 4 years ago

No. we didn't try it.

Setting modulus of r_i to 1 enables us to get the inverse operation of r by simple complex conjugation.

If we remove the modulus constraint, it may cause numerical problems when calculating the inverse operation.