DeepGraphLearning / torchdrug

A powerful and flexible machine learning platform for drug discovery
https://torchdrug.ai/
Apache License 2.0
1.42k stars 200 forks source link

The accuracy of retrosynthesis are different from the paper #162

Closed z15544534 closed 1 year ago

z15544534 commented 1 year ago

Hello, Thanks for sharing this library! The results of https://torchdrug.ai/docs/tutorials/retrosynthesis.html are different from the G2Gs. For reaction class is un-known, these are the reported results from the paper: top-1 accuracy: 0.489 top-3 accuracy: 0.676 top-5 accuracy: 0.725 top-10 accuracy: 0.755 These are the reported results from the https://torchdrug.ai/docs/tutorials/retrosynthesis.html: top-1 accuracy: 0.47541 top-3 accuracy: 0.741803 top-5 accuracy: 0.827869 top-10 accuracy: 0.879098 I cannot understand why the result of k>2 is higher than reported in the literature. Thank you very much

KiddoZhu commented 1 year ago

The implementation of G2Gs here is improved compared to TorchDrug. Check this reply from the author. Also the variational part is removed from the reactant generation module, which might contribute to some improvement if I recall correctly.

KiddoZhu commented 1 year ago

Duplicate of #103.