search

DeepIGM / dla_cnn

Pipeline to detect Ly-alpha emission lines in the SDSS3 catalog sightlines. Uses convolutional neural networks to classify sightlines, locate DLAs, and measure column density.
MIT License
9 stars 7 forks source link

update for generating summary table #37

Closed ZechangSun closed 4 years ago

ZechangSun commented 4 years ago

Dear X, This PR is about generating summary table for a given list of dla_cnn.data_model.Sigthline.Sightline objects. The detail of this part can be seen at dla_cnn\desi\preprocess.py\generate_summary_table. I changed something of dla_cnn\data_model\Sigthline.py and dla_cnn\desi\DesiMock.py to generate the summary table. Besides I have uploaded a Jupyter notebook dla_cnn\desi\nb\generate summary table.ipynb to show the summary table we got.

Best, Zechang Sun

ZechangSun commented 4 years ago

Move the code in the Generate Summary Table into a module, ideally one that can be run from a script (see dla_cnn/scripts/analyze_sl.py and I'll approve.

Thanks!

Hi, Prof. X. I have just moved the Generate Summary Table into the desi\scripts\generate_summary_table.py module, and it can be directly run from a script. I have also added more criteria in the code to identify whether a spectrum can be used for sample after discussing with @zoujiaqi99 . Sorry that I didn't notice this review in time. I will check my gmail regularly next time.