DeepLabCut / napari-deeplabcut

a napari plugin for labeling and refining keypoint data within DeepLabCut projects
GNU Lesser General Public License v3.0
52 stars 22 forks source link

Added keypoint matplotlib viewer #90

Closed hausmanns closed 1 year ago

hausmanns commented 1 year ago

Matplotliib viewer to view your keypoints' trajectory synced with the video and keypoints.

Activate plugin, upload your .h5 (and video, not necessary), and tick "show matplotlib trajectory"

image

https://github.com/DeepLabCut/napari-deeplabcut/assets/37653619/2cc70a56-f8ef-4c0c-a252-d133054e6193

codecov-commenter commented 1 year ago

Codecov Report

Merging #90 (ff625fa) into main (4d34cd2) will decrease coverage by 0.13%. Report is 6 commits behind head on main. The diff coverage is 82.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   83.18%   83.05%   -0.13%     
==========================================
  Files          11       11              
  Lines        1540     1688     +148     
==========================================
+ Hits         1281     1402     +121     
- Misses        259      286      +27     
Files Changed Coverage Δ
src/napari_deeplabcut/_widgets.py 73.36% <82.00%> (+1.83%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

deprecated-napari-hub-preview-bot[bot] commented 1 year ago

Preview page for your plugin is ready here: https://preview.napari-hub.org/DeepLabCut/napari-deeplabcut/90 Updated: 2023-08-31T08:05:01.184269

jeylau commented 1 year ago

https://github.com/DeepLabCut/napari-deeplabcut/assets/30733203/ae3699c3-f08a-41f2-9c8f-d4fb6623fee1

jeylau commented 1 year ago

Probably a couple of tweaks that could be made here and there; but that works very smoothly even for maDLC.

hausmanns commented 1 year ago

Another thing that should be tweaked @jeylau :

They y_lim should be independent of the dataset and dependent on the plot window (or adjustable) Indeed, keypoint jumps can squeeze the window depending on the dataset's quality

jeylau commented 1 year ago

Good point; one thing that could be added then is a NavigationToolbar2QT, which would allow panning, zooming, etc.

MMathisLab commented 1 year ago

Is this superseded by #92 ?

jeylau commented 1 year ago

@MMathisLab, these 2 PRs are distinct components. I will add the toolbar Seb mentioned above so this one is ready 😊

jeylau commented 1 year ago

Also, regarding the warnings in the console, they will be removed with napari's next release and vispy >= 0.13 https://github.com/napari/napari/pull/6025

MMathisLab commented 1 year ago

I think we need to address failing tests here before merge, right?

jeylau commented 1 year ago

Mhhh, napari removed the plugin preview service https://github.com/chanzuckerberg/napari-hub/discussions/1216. I'll delete the github action.

MMathisLab commented 1 year ago

so, ready to merge?

jeylau commented 1 year ago

Yes, looking good to me!